Add HTTP Auth and SSL to the ES output plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility. (by Hao Chen) Closes #1791
The typical use case is the placement of a transparent proxy in front of
ES. This PR enables basic Auth and HTTPS to be configured independently.
This patch makes logstash use only elasticsearch-ruby gem when writing
to elasticsearch. Also leverages the manticore http transport that ships
with es-ruby for the basic http auth and ssl features.
It's possible to configure the CA certificate using either a .pem/.cer
file ("cacert" option), or a .jks truststore ("truststore" option).
|
@jsvd can we merge this? I see reviews in elastic/logstash#1777 |
|
|
|
All comments have been addressed, so if there are no others, it's a "go". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as elastic/logstash#1777